Wire up the ZiplineDumpTask to the Zipline Gradle plugin #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
force-pushed
the
jwilson.0620.plugin
branch
from
45a1ae1
to
37c1573
Compare
swankjesse
commented
Jun 20, 2023
| @@ -74,6 +76,12 @@ class ZiplinePlugin : KotlinCompilerPluginSupportPlugin { | |||
| it.dependsOn(kotlinWebpack) | |||
| } | |||
| } | |||
|
|
|||
| target.tasks.withType(KotlinCompile::class.java) { kotlinCompile -> | |||
| if (kotlinCompile.name == "compileKotlinJvm") { | |||
There was a problem hiding this comment.
I’m not totally sure how to bootstrap this
There was a problem hiding this comment.
I suspect the check task will need to run on every target to ensure the interface is the same everywhere. Otherwise you could expect/actual and break yourself, or have completely different interfaces in different targets.
Not sure about the task to write it out, then. Maybe we just pick the first target? We're not guaranteed to have a JVM target (and doing things based on task name is generally discouraged anyway).
There was a problem hiding this comment.
I like that a lot. Added this advice as a note on the tracking issue.
JakeWharton
approved these changes
Jun 21, 2023
swankjesse
force-pushed
the
jwilson.0620.make_api_compatibility_decisions
branch
from
78bf3b3
to
77d1baa
Compare
Base automatically changed from
jwilson.0620.make_api_compatibility_decisions
to
trunk
June 22, 2023 02:24
swankjesse
force-pushed
the
jwilson.0620.plugin
branch
from
37c1573
to
0d03617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.