Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading and writing Zipline APIs as TOML #1051

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

swankjesse
Copy link
Contributor

I didn't introduce a dependency on a 3rd-party TOML library. I'm open to this, but it might make it difficult to write comments. (I'm less concerned with reading comments.)

I'm also anxious about how any dependency will interact with Gradle's classpath.

@JakeWharton
Copy link
Member

I'm also anxious about how any dependency will interact with Gradle's classpath.

This is why all of Redwood's build logic exists in an executable jar because it gets its own classpath completely divorced from the Gradle build.

You may also have problems with your use of the embeddable Kotlin compiler in the other PR and mixing it onto classpaths with the Android Gradle plugin and its use within lint.

I didn't introduce a dependency on a 3rd-party TOML library. I'm open to this, but it might make it difficult to write comments. (I'm less concerned with reading comments.)

Yeah writing with comments would always have to be done manually. I assumed you'd use one for reading it back, though since parsing is 1000x more code than a bunch of appends. Don't really care either way as the code should basically never have to change once it's working.

Base automatically changed from jwilson.0619.api_dump_fir to trunk June 21, 2023 20:09
I didn't introduce a dependency on a 3rd-party TOML library.
I'm open to this, but it might make it difficult to write
comments. (I'm less concerned with reading comments.)

I'm also anxious about how any dependency will interact
with Gradle's classpath.
@swankjesse swankjesse force-pushed the jwilson.0620.read_and_write_toml branch from 2ad2bf5 to 5a1a400 Compare June 21, 2023 20:12
@swankjesse
Copy link
Contributor Author

Fortunately the embeddable compiler is a compileOnly dependency. But I dig your strategy of forking to a CLI. I’ll do that too.

@swankjesse swankjesse enabled auto-merge (squash) June 21, 2023 20:14
@swankjesse swankjesse merged commit 24fbc30 into trunk Jun 21, 2023
6 checks passed
@swankjesse swankjesse deleted the jwilson.0620.read_and_write_toml branch June 21, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants