Use FIR to dump ZiplineService declarations #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I considered using KSP but it's awkard to generate artifacts from KSP during compile that the compile task doesn't itself need. Working towards #1047
swankjesse
commented
Jun 20, 2023
| * Type information that instances of `ZiplineServiceAdapter` instances need at construction time. | ||
| * Use [BridgedInterface.adapterConstructorArguments] to create an instance. | ||
| */ | ||
| class AdapterConstructorArguments( |
There was a problem hiding this comment.
This is a weird diff; I removed an unused file
swankjesse
commented
Jun 20, 2023
| private val FirFunction.isNonInterfaceFunction: Boolean | ||
| get() = symbol.name.identifier in NON_INTERFACE_FUNCTION_NAMES | ||
|
|
||
| private fun FirFunction.asDeclaredZiplineFunction(): DeclaredZiplineFunction { |
There was a problem hiding this comment.
There’s annoying duplication between this and the compiler plugin. The compiler plugin is IR, this is FIR, and we can’t have nice things.
JakeWharton
approved these changes
Jun 21, 2023
Comment on lines
+80
to
+82
| // TODO Figure out how to add the JDK modules to the classpath. Currently importing the stdlib | ||
| // allows a typealias to resolve to a JDK type which doesn't exist and thus breaks analysis. | ||
| configuration.addJvmClasspathRoots(dependencies.filter { "kotlin-stdlib-" !in it.path }) |
There was a problem hiding this comment.
Feel free to figure this out so I can steal the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered using KSP but it's awkard to generate artifacts from KSP during compile that the compile task doesn't itself need.
Working towards #1047