Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to ignore Content-Type header. #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added option to ignore Content-Type header. #75

wants to merge 1 commit into from

Commits on Aug 2, 2023

  1. Added option to ignore Content-Type header. 

    A kwarg parameter named ignore_content_type was added to get_pac and download_pac. The rationale for adding a new parameter is that it maintain the best backwards compatibility and ease of use. Also considered using accepting a specific value for allowed_content_types. However, I believe that this may be unexpected for current users. The arg was placed before the 'session' arg in order to maintain related args together. However, it risks breaking usages where all the parameters are positional.
    @KarelChanivecky
    KarelChanivecky authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    cd9e974 View commit details
    Browse the repository at this point in the history