Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix2582 corporate workshop costs #2626

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

maneesha
Copy link
Contributor

@maneesha maneesha commented Apr 3, 2024

Fixes #2582 by removing any direct references to workshop cost, and only referencing The Carpentries website.

@maneesha
Copy link
Contributor Author

maneesha commented Apr 3, 2024

I will come back to this to fix those linting errors. @pbanaszkiewicz If I do so, would you recommend running additional migrations or deleting the migrations in this PR and replacing them?

@pbanaszkiewicz
Copy link
Contributor

@maneesha There's a good chance that if you fix this kind of error in the both models.py files, you won't need a new migration.

@pbanaszkiewicz
Copy link
Contributor

@maneesha do you want this merged into v4.3?

@maneesha
Copy link
Contributor Author

@pbanaszkiewicz Yes, but I never got a chance to come back to fix this. Linting errors caused me to get lost in a sea of merge conflicts.

@pbanaszkiewicz pbanaszkiewicz self-assigned this Oct 7, 2024
@pbanaszkiewicz pbanaszkiewicz added this to the v4.3 milestone Oct 7, 2024
@pbanaszkiewicz pbanaszkiewicz force-pushed the fix2582-corporate-workshop-costs branch from af3572c to cabec3d Compare October 7, 2024 21:04
@pbanaszkiewicz pbanaszkiewicz merged commit 7e85c16 into develop Oct 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text about costs for corporate/for-profit workshops
2 participants