Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed icon password visibility in FluidPasswordInput #16496

Merged
merged 11 commits into from
May 21, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented May 17, 2024

Closes #16314

Added classes to fix the button visibility postion when the FluidPasswordInput is Invalid.

Testing / Reviewing

  • Go to FluidPasswordInput and add an invalid prop to true.
  • Make sure there is no regressions.

Copy link

netlify bot commented May 17, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9e622da
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/664c8d57b394720008080aa5
😎 Deploy Preview https://deploy-preview-16496--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 17, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9e622da
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/664c8d573ff0e6000803b808
😎 Deploy Preview https://deploy-preview-16496--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fluid looks great, but looks like this also changed the default styling.

Screenshot 2024-05-17 at 1 06 22 PM

@guidari
Copy link
Contributor Author

guidari commented May 20, 2024

Fluid looks great, but looks like this also changed the default styling.

Now it is working both components. @alisonjoseph

Screenshot 2024-05-20 at 10 07 04

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing some visual issues with invalid state, all other states and variants seem ok.

Screenshot 2024-05-20 at 12 57 27 PM

@guidari guidari requested a review from alisonjoseph May 21, 2024 12:02
@guidari
Copy link
Contributor Author

guidari commented May 21, 2024

I'm still seeing some visual issues with invalid state, all other states and variants seem ok.

@alisonjoseph
Screenshot 2024-05-21 at 08 56 05

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@Gururajj77 Gururajj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@guidari guidari added this pull request to the merge queue May 21, 2024
@guidari guidari removed this pull request from the merge queue due to a manual request May 21, 2024
@guidari guidari added this pull request to the merge queue May 21, 2024
Merged via the queue into carbon-design-system:main with commit 36bd564 May 21, 2024
21 checks passed
@guidari guidari deleted the 16314-password branch May 21, 2024 18:38
@carbon-automation
Copy link
Contributor

Hey there! v11.58.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: FluidTextInput has a bug with invalid and isPassword state
3 participants