Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowEmpty
attribute torequired
.allowEmpty
makes no sense, it should always berequired
to match baseHTML input
atrributes.invalid state
with a red outline and the validity of the input would stayvalid
(only if empty). This patch fix this.** NOTE TO DISCUSS : This bug was caused by the ambiguity between
invalid
anderror
variables. I think that we need to remove theexport invalid
and let it be local only. If OP wants to validate the input, we can export thepattern
or change thesetCustomValidity
with theref
. Since this PR check the validity of the input oninput
andchange
, thesetCustomValidity
will set the error.** Edit : I forgot to link the issue #1583 . -_-