Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FreeScout Helpdesk #1082

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added FreeScout Helpdesk #1082

wants to merge 2 commits into from

Conversation

houndbee
Copy link

@houndbee houndbee commented Mar 6, 2024

  • Added freescout.yaml and logofile

☑️ Self Check before Merge

  • [X ] I have tested the template using the method described in README.md thoroughly
  • [X ] I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • [X ] I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • [ X] I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • [ X] Icon is added as a png file to the logos directory.
  • [ X] I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter (If failling run the prettier: npm run formatter-write)
  • [ X] I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

* Added freescout.yaml and logofile
* Ran npm run formatter-write
Copy link
Collaborator

@githubsaturn githubsaturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and apologies for the late response!

Just one minor comment.

- $$cap_appname-db
image: tiredofit/freescout:$$cap_freescout_version
volumes:
- $$cap_appname-data:/www/html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this as it adds little value and users cannot upgrade simply by deploying new image. This is the directory where the source code lives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants