Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated versions, used more secure defaults, added req'd vars #1055

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nativeit
Copy link
Contributor

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter (If failling run the prettier: npm run formatter-write)
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

Changelog:

  • Added hmac_key to config variables--this was missing from previous versions, and no longer worked using more recent releases.
  • Replaced fixed username/passwords with variables.
  • Replaced fixed password variables with randomly generated hex.
  • Added additional links to configuration examples and guides.
  • Added note to app description defining minimum hardware requirements.
  • Bumped versions to match those currently used in official repo
  • Added config bind directory (previously just had DB data)
  • Tested for proper functioning using 100% default values with only the App Name variable set/changed

@githubsaturn
Copy link
Collaborator

Amazing! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants