Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lightdash #1028

Closed
wants to merge 6 commits into from
Closed

Add Lightdash #1028

wants to merge 6 commits into from

Conversation

samuelcecilio
Copy link

@samuelcecilio samuelcecilio commented Nov 29, 2023

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter (If failling run the prettier: npm run formatter-write)
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

Copy link
Collaborator

@githubsaturn githubsaturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. There are a couple of comments. Also, please make sure to run formatter-write before your commit. Also, please check all the boxes in the PR.

public/v4/apps/lightdash.yml Outdated Show resolved Hide resolved
public/v4/logos/lightdash.png Outdated Show resolved Hide resolved
public/v4/apps/lightdash.yml Outdated Show resolved Hide resolved
public/v4/apps/lightdash.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants