Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding in Python 3.12 support, warnings, and doc updates #301

Merged
merged 3 commits into from
May 23, 2024
Merged

adding in Python 3.12 support, warnings, and doc updates #301

merged 3 commits into from
May 23, 2024
+35 −12

Conversation

fdosani
Copy link
Member

@fdosani fdosani commented May 22, 2024 •
edited

3.12 tweaks:

  • Moving polars from extras to main dependencies
  • updating docs to make note about 3.12+
  • adding warning about 3.12+ on import

Fixes: #262
Fixes: #302

gladysteh99
gladysteh99 approved these changes May 23, 2024
View reviewed changes
Copy link

@gladysteh99 gladysteh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fdosani fdosani merged commit d3ca070 into develop May 23, 2024
30 checks passed
@fdosani fdosani deleted the python-312-update branch May 23, 2024 15:07
@fdosani fdosani mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdawang jdawang jdawang approved these changes

@gladysteh99 gladysteh99 gladysteh99 approved these changes

@ak-gupta ak-gupta Awaiting requested review from ak-gupta ak-gupta is a code owner

@NikhilJArora NikhilJArora Awaiting requested review from NikhilJArora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v0.12.0 doesn't appear to have LegacySparkCompare Are there plans to support Python 3.12.1?
3 participants
@fdosani @jdawang @gladysteh99