feat(barcode-scanning): support cornerPoints in readBarcodesFromImage(...)
#100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readbarcodesFromImage would return nothing(result or error) on an image not containing any barcode.
nurfgun
changed the title
|
did the same for android for missing corner points. |
robingenz
changed the title
cornerPoints in readBarcodesFromImage(...)
robingenz
requested changes
Nov 24, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@capacitor-mlkit/barcode-scanning", | |||
| "version": "5.3.0", | |||
| "version": "5.3.1", | |||
| @@ -30,7 +30,14 @@ public static JSObject createBarcodeResultForBarcode(@NonNull Barcode barcode, @ | |||
| cornerPointsResult.put(cornerPointResult); | |||
| } | |||
| } | |||
|
|
|||
| else if (cornerPoints != null) { | |||
There was a problem hiding this comment.
This also affects the scan(...) method and leads to invalid values there, as these would have to be normalized.
For now, my suggestion is to make this dependent on the screenSize parameter. If this parameter is set, corner points may only be returned normalized. I will improve this later.
Suggested change
| else if (cornerPoints != null) { | |
| else if (cornerPoints != null && screenSize == null) { |
Make sure that the screenSize parameter is null only for the readBarcodesFromImage(...) method.
Please also apply this to iOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset).This improved two things :
Close #39 and for my personal usage