Update bin/readability to work with Ruby 3.x #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes should be backwards compatible with older Ruby versions
according to the docs and testing it on Ruby 2.7.
Changes:
1. Use `require_relative` to avoid loading errors.
2. Use `URI.parse(...).read` instead of `open(...).read`
- This seems to be backwards compatible with older Ruby versions.
- Ex. https://www.rubydoc.info/stdlib/open-uri/2.3.1/OpenURI
- The behavior should be identical to what we saw before.
- `open(...).read` got deprecated in Ruby 3.0
|
Thanks @apainintheneck! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should be backwards compatible with older Ruby versions according to the docs and testing it on Ruby 2.7 and 3.2.
Changes:
require_relativeto avoid loading errors.URI.parse(...).readinstead ofopen(...).readopen(...).readgot deprecated in Ruby 3.0Do you think it's worth adding an integration test for this on CI?
Something like this would probably work to sanity check this. Probably would need to add more Rubies to CI though to make it a better check. Maybe not worth the effort.