Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Remote desktop portal #73

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

aospiridonov
Copy link
Contributor

Add Remote desktop portal

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #73 (682c4a5) into main (efd8e66) will decrease coverage by 5.22%.
The diff coverage is 79.73%.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   99.04%   93.81%   -5.23%     
==========================================
  Files          16       18       +2     
  Lines         627      841     +214     
==========================================
+ Hits          621      789     +168     
- Misses          6       52      +46     
Impacted Files Coverage Δ
lib/src/xdg_remote_desktop_portal.dart 73.91% <73.91%> (ø)
lib/src/xdg_documents_portal.dart 91.83% <91.83%> (ø)
lib/src/xdg_desktop_portal_client.dart 93.10% <100.00%> (+1.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@robert-ancell
Copy link
Contributor

This is a big change - I'm not going to be able to review this until #71 lands. You might consider breaking off smaller changes into separate PRs that can be more easily reviewed and landed.

@robert-ancell
Copy link
Contributor

I've landed a stub portal commit for this - we can build off that.

@aospiridonov
Copy link
Contributor Author

This is a big change - I'm not going to be able to review this until #71 lands. You might consider breaking off smaller changes into separate PRs that can be more easily reviewed and landed.

I didn't understand. What should I do for this?

@robert-ancell
Copy link
Contributor

This is a big change - I'm not going to be able to review this until #71 lands. You might consider breaking off smaller changes into separate PRs that can be more easily reviewed and landed.

I didn't understand. What should I do for this?

For example, make a PR with just the getAvailableDeviceTypes() change. That should be quick to review and land. Then continue to do that for the other changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants