-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for the uv plugin #5196
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
Needs canonical/craft-parts#956 for test failures |
@bepri I fixed the duplicate label errors in 5fd0578. However, this uncovered another, grosser error. The Go plugin reference in Craft Parts links to the Go Use plugin. The only way to suppress the error is to index that page here, but as far as I know this plugin isn't available in Snapcraft. @mr-cal can you confirm? It seems like we need to escalate this upstream and maybe implement a rule where we don't cross-ref plugins. |
We can add the go-use page here to suppress the warning about it not being indexed. The go-use plugin wasn't part of snapcraft until this PR. Now it will be a snapcraft plugin. |
Unfortunately in the meantime the Go plugin page itself links to the Go-Use page. Excluding Go-Use results in a missing ref. Integration of Go-Use will be a blocker unless we change the upstream doc. |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
tests/spread/plugins/craft-parts/build-and-run-hello/uv-hello/src/pyproject.toml
Outdated
Show resolved
Hide resolved
requirements-devel.txt
Outdated
@@ -59,7 +59,7 @@ craft-grammar==2.0.1 | |||
# via | |||
# craft-application | |||
# snapcraft (setup.py) | |||
craft-parts==2.1.2 | |||
craft-parts @ git+https://github.com/canonical/craft-parts@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to revert this before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)Note to reviewers: The linter and docs build errors will be addressed in the next pulse with the help of @medubelko, you can just review the functionality of the uv plugin itself.
Closes #5187.
CRAFT-3841