Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for the uv plugin #5196

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

feat: support for the uv plugin #5196

wants to merge 27 commits into from

Conversation

bepri
Copy link
Contributor

@bepri bepri commented Jan 6, 2025

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Note to reviewers: The linter and docs build errors will be addressed in the next pulse with the help of @medubelko, you can just review the functionality of the uv plugin itself.

Closes #5187.
CRAFT-3841

@bepri bepri self-assigned this Jan 6, 2025
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

setup.py Outdated Show resolved Hide resolved
snapcraft/parts/plugins/uv_plugin.py Outdated Show resolved Hide resolved
@bepri bepri changed the title Work/uv plugin/craft 3841 feat: support for the uv plugin Jan 7, 2025
@bepri
Copy link
Contributor Author

bepri commented Jan 7, 2025

Needs canonical/craft-parts#956 for test failures

@medubelko
Copy link
Contributor

medubelko commented Jan 9, 2025

@bepri I fixed the duplicate label errors in 5fd0578.

However, this uncovered another, grosser error. The Go plugin reference in Craft Parts links to the Go Use plugin. The only way to suppress the error is to index that page here, but as far as I know this plugin isn't available in Snapcraft.

@mr-cal can you confirm? It seems like we need to escalate this upstream and maybe implement a rule where we don't cross-ref plugins.

@mr-cal
Copy link
Collaborator

mr-cal commented Jan 9, 2025

@bepri I fixed the duplicate label errors in 5fd0578.

However, this uncovered another, grosser error. The Go plugin reference in Craft Parts links to the Go Use plugin. The only way to suppress the error is to index that page here, but as far as I know this plugin isn't available in Snapcraft.

@mr-cal can you confirm? It seems like we need to escalate this upstream and maybe implement a rule where we don't cross-ref plugins.

We can add the go-use page here to suppress the warning about it not being indexed.

The go-use plugin wasn't part of snapcraft until this PR. Now it will be a snapcraft plugin.

@medubelko
Copy link
Contributor

We can add the go-use page here to suppress the warning about it not being indexed.

Unfortunately in the meantime the Go plugin page itself links to the Go-Use page. Excluding Go-Use results in a missing ref.

Integration of Go-Use will be a blocker unless we change the upstream doc.

@bepri bepri requested review from lengau, dariuszd21 and mr-cal January 13, 2025 17:25
@tigarmo
Copy link
Contributor

tigarmo commented Jan 13, 2025

The go-use plugin should work without customizations in snapcraft. The docs don't need to be excluded, they need to be explicitly added to the plugins index

Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bepri bepri marked this pull request as ready for review January 15, 2025 18:29
@@ -59,7 +59,7 @@ craft-grammar==2.0.1
# via
# craft-application
# snapcraft (setup.py)
craft-parts==2.1.2
craft-parts @ git+https://github.com/canonical/craft-parts@main
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to revert this before merging

Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog LGTM.

@mr-cal mr-cal added the squash label Jan 16, 2025
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

requirements-docs.txt Show resolved Hide resolved
@bepri bepri enabled auto-merge (squash) January 17, 2025 19:42
@bepri bepri disabled auto-merge January 17, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for uv plugin
7 participants