Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor the ${pcfiledir} entries in pkgconfig #5157

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sergio-costas
Copy link
Contributor

@sergio-costas sergio-costas commented Nov 27, 2024

The ${pcfiledir} tag allows to make .pc files relocatables, by being replaced with the path where the .pc file is stored. In these cases, the "prefix=" entry must be left as-is, to ensure that it continues to work as expected.

It is complemented by canonical/craft-parts#977

Fix #5158

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

The ${pcfiledir} tag allows to make .pc files relocatables, by
being replaced with the path where the .pc file is stored. In
these cases, the "prefix=" entry must be left as-is, to ensure
that it continues to work as expected.
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (654871d) to head (aa6ed53).
Report is 675 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (654871d) and HEAD (aa6ed53). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (654871d) HEAD (aa6ed53)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5157      +/-   ##
==========================================
- Coverage   94.88%   89.71%   -5.17%     
==========================================
  Files         658      342     -316     
  Lines       55189    22642   -32547     
==========================================
- Hits        52364    20313   -32051     
+ Misses       2825     2329     -496     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapcraft doesn't honor ${pcfiledir} in pkgconfig files
1 participant