Merge pull request #166 from facundobatista/dont-ignore-version

Don't ignore important files (like version) by default.

charmcraft/jujuignore.py

@@ -211,6 +211,8 @@ def match(self, path: str, is_dir: bool) -> bool:
 
 # default_juju_ignore is the initial set of ignores.
 # juju itself always includes these before adding the contents of .jujuignore
+# NOTE that this diverges from Juju ignore list, which also ignores "version",
+# because we need the version file to populate the store
 default_juju_ignore = '''
 .git
 .svn
@@ -220,7 +222,6 @@ def match(self, path: str, is_dir: bool) -> bool:
 
 /build/
 /revision
-/version
 
 .jujuignore
 '''.split('\n')

tests/test_jujuignore.py

@@ -23,6 +23,12 @@
 from charmcraft import jujuignore
 
 
+def test_default_important_files():
+    """Don't ignore important files by default."""
+    ignore = jujuignore.JujuIgnore(jujuignore.default_juju_ignore)
+    assert not ignore.match('version', is_dir=False)
+
+
 def test_jujuignore_only_dir():
     ignore = jujuignore.JujuIgnore(['target/'])
     assert ignore.match('target', is_dir=True)