refactor(iOS): Migrate RCTOnPageSelected to swift #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troZee
reviewed
Dec 2, 2024
| @@ -2,3 +2,4 @@ | |||
| #import <React/RCTUIManager.h> | |||
| #import <React/UIView+React.h> | |||
| #import <React/RCTUtils.h> | |||
| #import <React/RCTAssert.h> | |||
troZee
approved these changes
Dec 2, 2024
troZee
approved these changes
Dec 2, 2024
krozniata
reviewed
Dec 3, 2024
There was a problem hiding this comment.
nit: rename file so it matches class name
okwasniewski
reviewed
Dec 3, 2024
| import Foundation | ||
| import React | ||
|
|
||
| @objc public class RCTOnPageSelected: NSObject, RCTEvent { |
Comment on lines
+20
to
+23
| @objc public func canCoalesce() -> Bool { | ||
| return false | ||
| } | ||
|
|
There was a problem hiding this comment.
If canCoalesce is false you don't need to have coalescingKey and public func coalesce(with newEvent: RCTEvent) -> RCTEvent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md