Update CocoaLumberjack to 3.0.0 #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Jan 12 2017 * 1d361a83599948b0110c12946a8cf75a37f295f2
for Lumberjack 3.0.0
|
Jenkins test this please |
|
Jenkins failed - Xcode 7.3.1 vs Xcode 8.2.1 |
jmoody
deleted the
feature/update-CocoaHTTPServer-Lumberjack-definitions
branch
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is possible that NSLog is interfering with XCUITest execution. This was the case with UIAutomation.
Replacing NSLog with DDLogDebug is not a silver bullet - my initial tests did not show any definitive improvement. Replacing NSLog with Lumberjack does have merit because Lumberjack is faster and replacing NSLog will obviate any concerns about NSLog clobbering XCUITest.
Modernizing the CocoaHTTPServer logging definitions is a requirement for updating to CocoaLumberjack >= 2.0.
Provenance
Related
We should treat CocoaHTTPServer as unmaintained.