Output a JIRA key if found. #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakeinpanic
requested changes
Nov 2, 2023
| @@ -50,6 +50,7 @@ When a PR passes the above check, `jira-description-action` will also add the is | |||
|
|
|||
| | key | description | |||
| | ---------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | | |||
| | `jira-issue-key` | The JIRA issue key. If key is not found the value is an empty string |**** | |||
There was a problem hiding this comment.
you also need to add it here, otherwise it won't work
https://github.com/cakeinpanic/jira-description-action/blob/master/action.yml
| function setOutputs(isFound: boolean, source: ESource | null): void { | ||
| function setOutputs(key: string, source: ESource | null): void { | ||
| var isFound = key !== ''; | ||
| core.setOutput('jira-issue-key', key); |
There was a problem hiding this comment.
I suggest to pass null instead of an empty string here, it's more straightforward IMHO
There was a problem hiding this comment.
Argument of type 'null' is not assignable to parameter of type 'string'.ts(2345)
I originally had it that way but my text editor is complaining (I'm not a javascript developer).
There was a problem hiding this comment.
it's a typescript error :)
please use key: string | null and it'd work well
Signed-off-by: Gregory Schofield <[email protected]>
gscho
force-pushed
the
output-jira-key
branch
from
452154b
to
1da4052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.