Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vuejs demo #98

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Add vuejs demo #98

merged 3 commits into from
Oct 4, 2023

Conversation

eokwukwe
Copy link
Contributor

@eokwukwe eokwukwe commented Sep 4, 2023

This repo is an attempt to add an example usage with vuejs using quill-vue

Copy link
Owner

@c-w c-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing the sample code. I'd be happy to merge a vueJS example, especially to document the work-around that we found on #97. However, I'd ask for a little bit of work to increase consistency with the other examples to make this more maintainable:

  1. Could you match the layout and style of the other example pages. To avoid coupling the example with a specific CSS framework such as Tailwind, stick with pure CSS. You can copy the stylesheet from one of the other demos.
  2. Could you simplify the example by removing unused files such as the various SVGs, README, etc.
  3. The other demos use a consistent API in the NPM scripts: start to run the development server and build to compile the production bundle. Could you make the vueJS example also follow this approach.
  4. Nit: rename the folder to vuejs.

Once these minor changes are taken care of, I'll add the integration with the build/publish pipeline so that we can get the example deployed.

Thank you! 🙌

@eokwukwe
Copy link
Contributor Author

@c-w Thank you for working on this. Please confirm that the changes you requested have been made.

Thank you for providing the sample code. I'd be happy to merge a vueJS example, especially to document the work-around that we found on #97. However, I'd ask for a little bit of work to increase consistency with the other examples to make this more maintainable:

  1. Could you match the layout and style of the other example pages. To avoid coupling the example with a specific CSS framework such as Tailwind, stick with pure CSS. You can copy the stylesheet from one of the other demos.
  2. Could you simplify the example by removing unused files such as the various SVGs, README, etc.
  3. The other demos use a consistent API in the NPM scripts: start to run the development server and build to compile the production bundle. Could you make the vueJS example also follow this approach.
  4. Nit: rename the folder to vuejs.

Once these minor changes are taken care of, I'll add the integration with the build/publish pipeline so that we can get the example deployed.

Thank you! 🙌

Copy link
Owner

@c-w c-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, I'm noting a few remaining points.

rvuejs/.gitignore Outdated Show resolved Hide resolved
vuejs/src/App.vue Show resolved Hide resolved
vuejs/index.html Outdated Show resolved Hide resolved
vuejs/index.html Outdated Show resolved Hide resolved
Copy link
Owner

@c-w c-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you; I'm working on getting this integrated and will merge.

@c-w c-w changed the title Add an example usage with vuejs using quill-vue Add vuejs demo Oct 4, 2023
@c-w c-w merged commit 1af8425 into c-w:master Oct 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants