Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial functionality #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add initial functionality #1

wants to merge 4 commits into from

Conversation

jmduke
Copy link
Member

@jmduke jmduke commented Sep 22, 2023

Remaining work before merging

  • Write an actual README
  • Replace BUTTONDOWN_APPS with a settings abstraction for declaring which apps have checkers
  • Replace references to https://admin.buttondown.email with SITE_URL
  • Replace json_table_widget.html's hardcoding of specific models with something more clever
  • Remove dependence on requests, rich, related_admin, humanize, fieldsignals
  • Replace reactions defaults with something more configurable
  • Actual project/pip stuff
  • Squash migrations

checker_run.save()
for failure in collected_failures:
failure.checker_run = checker_run
CheckerFailure.objects.bulk_create(collected_failures)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you ever do open-source this project fully and publish as a package, I needed to add this logic to handle the fact that we use UUID PKs not integer PKs, and the default UUID object is not JSON-serializable:

for failure in collected_failures:
    failure.data = json.dumps(failure.data, cls=DjangoJSONEncoder)

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironically i also use UUID PKs and run into this all the time and did not think to just serialize it at this level...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants