Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split shortcuts by platform and name them #789

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lukemelia
Copy link
Contributor

@lukemelia lukemelia commented Sep 18, 2023

This is a rebase and modernization of @hpohlmeyer's #591.

Our use case is that we need to unregister the default toggleLink commands to replace them with our own more sophisticated link editing UI.

Note that before this PR, both Mac and Windows-style shortcuts worked on both platforms. After this PR, Mac gets standard mac shortcuts (mostly Command + ...) and other platforms get standard Windows shortcuts (mostly Ctrl + ...). I think this is preferable and makes the code clearer. However, if this change is not desirable, I can revise this PR to only add names and not split commands by platform.

@lukemelia
Copy link
Contributor Author

CI failures are related to sauce labs credentials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants