Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tidymodels dependency + Silence R CMD CHECK warnings #155

Merged
merged 10 commits into from
Oct 3, 2023
Merged

Remove tidymodels dependency + Silence R CMD CHECK warnings #155

merged 10 commits into from
Oct 3, 2023

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Oct 3, 2023

  • Delete the docs/ directory (gh-pages branch allows to follow changes made to the website) + add to .gitignore
  • Use testthat setting (without loading libraries)
  • More namespace
  • Remove unneeded library(timetk) in examples.
  • Remove dep on tidymodels, and yardstick.
  • Use dev version.
  • T -> TRUE, F -> FALSE
  • Use tidyselect::all_of() when specifying an external vector.
  • Silence timezone warnings in tests by adding a temporary expect_tz_warning() function before Warnings in tests #156 is fixed.

This reduces the number of dependencies to 127 (down from 148 at first),

@olivroy olivroy mentioned this pull request Oct 3, 2023
@olivroy olivroy changed the title Upkeep2 Remove tidymodels dependency + Silence R CMD CHECK warnings Oct 3, 2023
@olivroy
Copy link
Contributor Author

olivroy commented Oct 3, 2023

@mdancho84 , all CI pass now, let me know what you think!

@mdancho84 mdancho84 merged commit 182e485 into business-science:master Oct 3, 2023
7 checks passed
@mdancho84
Copy link
Contributor

Looks good. I'll check on my end after the merge.

One thing: there is a FANG data set with timetk. Please leave that one as is.

Just in case someone needs the old version I can have them use timetk FANG.

@olivroy olivroy deleted the upkeep2 branch October 3, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants