remove confusing messaging from login screen for already-logged-in user #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this "if_authz_failed" tag must've been a relic from the past, because in the current model, if you're authenticated, it doesn't really make sense to ask if you're generally "authorized". You can only be authorized in relation to a particular page or permission. #1508
srabraham
force-pushed
the
2025-01-06-modal-style
branch
from
7db43fa to
d729d26
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1511 +/- ##
==========================================
+ Coverage 69.70% 69.75% +0.04%
==========================================
Files 181 181
Lines 9148 9139 -9
Branches 1506 1503 -3
==========================================
- Hits 6377 6375 -2
+ Misses 2662 2654 -8
- Partials 109 110 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this "if_authz_failed" tag must've been a relic from the past, because in the current model, if you're authenticated, it doesn't really make sense to ask if you're generally "authorized". You can only be authorized in relation to a particular page or permission.
#1508