Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to strike/unstrike Field Report report entries #1510

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

srabraham
Copy link
Member

this lets the user strike/unstrike from both the Incident page and the Field Report page.

This adds a "show history" checkbox to the FR page, as we already had for the Incident page.
This also brings back option+enter for submitting report entries (something very useful on OSX, which I removed recently).

#249

this lets the user strike/unstrike from both the Incident page
and the Field Report page.

This also brings back option+enter for submitting report entries
(something very useful on OSX, which I removed recently).

#249
@srabraham srabraham enabled auto-merge (rebase) January 10, 2025 10:56
@srabraham srabraham disabled auto-merge January 10, 2025 11:01
@srabraham srabraham merged commit 9aee13f into master Jan 10, 2025
10 of 11 checks passed
@srabraham srabraham deleted the 2025-01-06-modal-style branch January 10, 2025 11:03
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 68.13187% with 29 lines in your changes missing coverage. Please review.

Project coverage is 69.70%. Comparing base (0b7db23) to head (cc7634c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ims/application/_api.py 0.00% 26 Missing ⚠️
src/ims/store/test/report.py 92.30% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1510      +/-   ##
==========================================
- Coverage   69.74%   69.70%   -0.04%     
==========================================
  Files         181      181              
  Lines        9070     9148      +78     
  Branches     1498     1506       +8     
==========================================
+ Hits         6326     6377      +51     
- Misses       2637     2662      +25     
- Partials      107      109       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srabraham
Copy link
Member Author

the CodeFactor alert was a complaint about _api.py being too complex, in that it now has 129 code paths. That seems kind of hard to avoid though

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant