Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restart Field Report numbering at 1 each event #1506

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

srabraham
Copy link
Member

@srabraham srabraham commented Jan 7, 2025

this makes FRs consistent with Incidents

FYI @wsanchez @virtual256 @kimballa

it'd be better still if we let the DB assign IDs directly using autoincrement, but that's a problem for another day. This just makes the incident and FR approaches the same

#1505

this makes FRs consistent with Incidents

#1505
@srabraham srabraham enabled auto-merge (rebase) January 7, 2025 17:33
@srabraham srabraham merged commit f81a58a into master Jan 7, 2025
11 checks passed
@srabraham srabraham deleted the 2025-01-06-modal-style branch January 7, 2025 17:34
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.72%. Comparing base (9f68e44) to head (169fbe0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
- Coverage   69.74%   69.72%   -0.03%     
==========================================
  Files         181      181              
  Lines        8985     8985              
  Branches     1489     1489              
==========================================
- Hits         6267     6265       -2     
- Misses       2613     2614       +1     
- Partials      105      106       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant