improve handling for potentially missed SSEs #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This starts telling EventSource clients, upon connection, which SSE ID was the most recently published. That allows the client to know whether it should reload its data pages to be in sync with the server. I store the previous SSE ID in LocalStorage, so that all tabs can share that value together. This makes the synchronization mechanism very resilient to the EventSource connection needing to be reestablished. This simplifies some of the _eventsource.py code by removing unused code around replaying events (we were never using that).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1504 +/- ##
==========================================
+ Coverage 69.64% 69.74% +0.10%
==========================================
Files 181 181
Lines 8998 8985 -13
Branches 1494 1489 -5
==========================================
Hits 6267 6267
+ Misses 2626 2613 -13
Partials 105 105 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts telling EventSource clients, upon connection, which SSE ID was the most recently published. That allows the client to know whether it should reload its data pages to be in sync with the server. I store the previous SSE ID in LocalStorage, so that all tabs can share that value together.
This makes the synchronization mechanism very resilient to the EventSource connection needing to be reestablished.
This simplifies some of the _eventsource.py code by removing unused code around replaying events (we were never using that).