add some resiliency around missed SSEs #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with my changes yesterday to only selectively update the Incidents page, i.e. only update one row at a time, it's even more important that we don't miss any SSEs. This change builds in some resiliency, by having the Incidents and Incident pages do more substantial reloads when an SSE is known to have been missed. I'm not sure this is the final version of what I want in prod on playa, but I'd like to try this out in staging, where the network connection is less reliable for me than from localhost.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1503 +/- ##
=======================================
Coverage 69.64% 69.64%
=======================================
Files 181 181
Lines 8998 8998
Branches 1494 1494
=======================================
Hits 6267 6267
Misses 2626 2626
Partials 105 105 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with my changes yesterday to only selectively update the Incidents page, i.e. only update one row at a time, it's even more important that we don't miss any SSEs. This change builds in some resiliency, by having the Incidents and Incident pages do more substantial reloads when an SSE is known to have been missed.
I'm not sure this is the final version of what I want in prod on playa, but I'd like to try this out in staging, where the network connection is less reliable for me than from localhost.
#1488