only update the changed incident on background update #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously on any update to any incident, we were pulling all the incident data for every incident in the event. That would lead to heavy server load when many users were logged into IMS at once, and it make the table spin waiting for the large bundle of new data to arrive. #1488
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1493 +/- ##
==========================================
+ Coverage 69.64% 69.67% +0.03%
==========================================
Files 181 181
Lines 8996 8996
Branches 1494 1494
==========================================
+ Hits 6265 6268 +3
+ Misses 2625 2624 -1
+ Partials 106 104 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously on any update to any incident, we were pulling all the incident data for every incident in the event. That would lead to heavy server load when many users were logged into IMS at once, and it make the table spin waiting for the large bundle of new data to arrive.
#1488