Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permit any calls to codecov.io #1410

Merged
merged 1 commit into from
Nov 14, 2024
Merged

permit any calls to codecov.io #1410

merged 1 commit into from
Nov 14, 2024

Conversation

srabraham
Copy link
Member

@srabraham srabraham commented Nov 14, 2024

There are apparently new calls in the codecov step to ingest.codecov.io,
and now all my CI runs are failing 😭.
It seems more futureproofed and minimally risky to just permit calls to any
subdomain of codecov.io

https://app.stepsecurity.io/github/burningmantech/ranger-ims-server/actions/runs/11836661205?jobid=32982019292&tab=network-events

codecov/codecov-action#1547 (comment)

Copy link
Contributor

⚠️ Optional matrix job Py:3.14.0-alpha.1 - ubuntu-latest failed ⚠️

  • tox prefix: test
  • exit status: 1

@srabraham srabraham requested a review from wsanchez November 14, 2024 12:57
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.09%. Comparing base (03df98e) to head (b1e0558).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1410      +/-   ##
==========================================
- Coverage   69.11%   69.09%   -0.03%     
==========================================
  Files         181      181              
  Lines        8937     8937              
  Branches     1496     1496              
==========================================
- Hits         6177     6175       -2     
- Misses       2661     2662       +1     
- Partials       99      100       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srabraham srabraham merged commit 4dc4553 into master Nov 14, 2024
13 checks passed
@srabraham srabraham deleted the 2024-11-14-harden branch November 14, 2024 12:58
@wsanchez
Copy link
Member

Ooh you can use wildcards. do the same with GitHub.io

@srabraham
Copy link
Member Author

Ooh you can use wildcards. do the same with GitHub.io

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants