Many files problem on OSX Sierra #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like there is a problem with fsevents when dealing with a large amount of files on OSX sierra this added test fails reliably on mac Macbook Pro, with the error ``` 2017-01-17 22:52 filemonitor.test[69205] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22) ``` This more or less reporduces #589 #605 #607 on the basis of this being related to many files the fix would be to not monitor files individualy on OSX but rather monitor directories and filter client side, this should reduce the number of files / directories to be monitored.
OSX is much more limited in the amount of files to keep open compared to other unixes since Sierra. So instead of monitoring files we monitor directories and assume a change in the directory warents a restart. This is less than ideal but should provide a quick fix for the current problem on Sierra erroring on large applications.
|
This has been released as 0.15.13.pre |
|
Thank you so much, @sideshowcoder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like there is a problem with fsevents when dealing with a large amount
of files on OSX sierra this added test fails reliably on mac Macbook Pro, with
the error
To test this up the count of files in
filemonitor_test.TestFileMonitorFiles,to something like
5000and the error will show up in the log when runningmake test-go.To fix this the proposed quick solution is to on OSX monitor directories instead
of files, when a file is added to the watch list compute the directory it is
contained in and monitor this directory via FSEvents. This can cause more
restarts than before.
fixes #607 #589