Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore directories from glob matching #381

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

donaldpiret
Copy link

The current glob.sync can match directories as well as files, which will then fail when trying to get the size of the file, this change ignores directories when performing the glob.

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

Could not find any unit tests in the codebase, am I missing something?

If relevant, link to documentation update:

Summary

The current glob match will match directories that match your file globs, eg. a files entry of .nuxt/dist/client/**/*.css

will match a file named .nuxt/dist/client/2.css/23r23.css
but also a directory named `.nuxt/dist/client/2.css`` and will thus fail on this dir.

This change skips any directory that matches the provided glob.

Does this PR introduce a breaking change?

Not as far as I'm aware

Other information

Couldn't find a great way to test this so could use some help validating that this change works as intended...

The current glob.sync can match directories as well as files, which will then fail when trying to get the size of the file, this change ignores directories when performing the glob.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant