-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write a script to run e2e test #237
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,5 @@ | |||
# frozen_string_literal: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this so we can run bktec
from this project using the default command bundle exec rspec ...
93a3c59
to
6c9f25f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been testing this this morning and think it could maybe use some automation/instruction around bootstrapping.
I'm getting an error relating to bundle install
not being run for the rspec test suite, and a module not found error when trying to run it for playwright.
I like this! This just enables running the tests for each language in the bktec repo yeah? One comment on the usage interface:
I understand why we'd wanna specify the framework as a top level argument into the script here, but I'm less convinced that the script should mandate passing in a parallel job? What possible variance do you see in this argument? IMO if parallel job count has a default then its fine that parallel job has one too |
6c9f25f
to
86eb84d
Compare
Yes, that's right
That's a good point. I've removed parallel job from the arg. You can still set that variable manually as
|
@wooly I created a |
Description
We now have four runners supported in
bktec
. Since we have sample projects for each test runner that we use for unit and integration tests, I thought it would be great to use those sample projects to run end-to-end tests. This PR adds a script that runsbktec
(usinggo run …
) against a sample project located ininternal/runner/testdata
.To run the e2e test:
#.bin/e2e <runner> <parallel-job> .bin/e2e rspec 0