Fix PATH used by jobs #1420
Open
Fix PATH used by jobs #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PATH configured in buildkite-agent.service is inherited by all jobs executed by Buildkite. Normally, a binary installed to `/usr/local/bin`, would take precedence over similarly named files in `/usr/bin` or `/bin`. This commit restores that expectation, allowing for an administrator to replace the default binary by installing its replacement into `/usr/local/bin`. There is no entry for `/bin` because al2023 symlinks `/usr/bin` to `/bin`. A specific entry for `/bin` is unnecessary. Finally, `/usr/local/sbin`, `/usr/sbin` have been removed because as the buildkite-agent is a regular user, it should not have the required permissions to use those binaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PATH configured in
buildkite-agent.serviceis inherited by all jobs executed by Buildkite.Normally, a binary installed to
/usr/local/binwould take precedence over similarly named files in/usr/binor/bin. This commit restores that expectation allowing an administrator to replace a binary by installing a replacement into/usr/local/bin.There is no entry for
/binbecause al2023 symlinks/usr/binto/bin. A specific entry for/binis unnecessary.Finally,
/usr/local/sbinand/usr/sbinhave been removed because as the buildkite-agent is a regular user, it should not have the required permissions to use those binaries.