Update bazelisk past v1.21.0 #8119
Merged
+45
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siggisim
approved these changes
Jan 6, 2025
bduffany
force-pushed
the
bazelisk-1.21.0
branch
from
9b3f35e to
3f1db24
Compare
|
If you update to the pseudo-version corresponding to bazelbuild/bazelisk@0a4dc6b, the repo names should be correct for both WORKSPACE and Bzlmod without the need for |
|
rebased version #8232 |
bduffany
force-pushed
the
bazelisk-1.21.0
branch
from
2507286 to
b3f1de5
Compare
bduffany
force-pushed
the
bazelisk-1.21.0
branch
from
4dc404a to
db00267
Compare
|
@keith sorry for the delay on this PR - I had to make a few more changes to it, pulling in Fabian's upstream fix in bazelisk + dealing with a few other breaking changes, but we should be good to go now. The PR now upgrades us a little past v1.25.0 (bazelbuild/bazelisk@0a4dc6b) |
|
np, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: the PR https://github.com/buildbuddy-io/buildbuddy/pull/8086/files originally wanted to bump bazelisk to v1.21.0, but there were some breakages relating to bazelisk renaming their go dependencies' repository names internally.
The original PR attempted to work around that renaming issue by using
repo_mapping, but we had some issues getting it to work.So, we're instead now reverting Gazelle's repo renaming change by upgrading our bazelisk dep to the pseudo-version at bazelbuild/bazelisk@0a4dc6b . This should address the original need for upgrading to v1.21.0 as it should have the latest bazelisk changes.
(Small note, this PR also bumps the bazelisk binaries downloaded with
http_fileto the latest released version, just to keep the CLI bazelisk version and ci_runner bundled bazelisk version reasonably close.)