Add webdriver test for action page #8117
Merged
+55
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action page breaks often because the
/file/download
logic is pretty complex as well as the logic ininvocation_action_card.tsx
. So, it seems worth expanding the existing webdriver test to not just check the executions listing for the test build, but also click through to the action page.To make this change, we need to update the current test to actually execute the build on an executor. Currently when the test build runs, it fails because there are no registered executors. The current test just asserts that the failed execution is displayed in the UI. By running an executor in the test, we can successfully run the execution and click through to the action page to see the action result.
This PR only tests a single auth scenario: the invocation is authenticated, and the user is logged in while trying to view the action page. I would like to expand this test in future PRs with more auth scenarios: