Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webdriver test for action page #8117

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Add webdriver test for action page #8117

merged 1 commit into from
Jan 7, 2025

Conversation

bduffany
Copy link
Member

@bduffany bduffany commented Jan 6, 2025

The action page breaks often because the /file/download logic is pretty complex as well as the logic in invocation_action_card.tsx. So, it seems worth expanding the existing webdriver test to not just check the executions listing for the test build, but also click through to the action page.

To make this change, we need to update the current test to actually execute the build on an executor. Currently when the test build runs, it fails because there are no registered executors. The current test just asserts that the failed execution is displayed in the UI. By running an executor in the test, we can successfully run the execution and click through to the action page to see the action result.

This PR only tests a single auth scenario: the invocation is authenticated, and the user is logged in while trying to view the action page. I would like to expand this test in future PRs with more auth scenarios:

  • Authenticated invocation, view while impersonating
  • Anonymous invocation, view while logged in + not logged in
  • Authenticated invocation made public, view while logged in + not logged in + impersonating

@jdhollen
Copy link
Member

jdhollen commented Jan 6, 2025

looks like the invocation webdriver test is failing

@bduffany
Copy link
Member Author

bduffany commented Jan 7, 2025

@jdhollen fixed - the ExecuteResponse is cached asynchronously after we return it to bazel, so the action page would occasionally show "not found" since we're navigating there right after the build completes. Fixed by refreshing a few times until it's cached

@bduffany
Copy link
Member Author

bduffany commented Jan 7, 2025

well, fixed locally anyway... seems there are more issues still happening on CI - looking

edit: deflaked; PTAL

@bduffany bduffany merged commit a2ce445 into master Jan 7, 2025
15 checks passed
@bduffany bduffany deleted the action-webtest branch January 7, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants