Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify connection disconnect during error handling of new connection … #7463

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Notify connection disconnect during error handling of new connection … #7463

wants to merge 3 commits into from

Commits on Apr 13, 2024

  1. Notify connection disconnect during error handling of new connection … 

    …from a

worker when there is already a known (but actually disconnected) connection
to the same worker.

This would otherwise cause a case of worker "knowing" it was "connected", while
the manager equally "know" that the worker was "offline" because it was not
attached to any builders, all the while the low-level connection maintenance
functionality kept sending and receiving keep-alives, thus keeping the unattached
connection open. (buildbot#4678)
    @YngveNPettersen
    YngveNPettersen committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    41d871d View commit details
    Browse the repository at this point in the history

  2. Close connection immediately during KeepAlive if it is not associated… 

    … with a worker (buildbot#4678)

This is a just-in-case-logic is the connection is somehow detached from all Builders, but still leaving the connection active
    @YngveNPettersen
    YngveNPettersen committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    e05a2ca View commit details
    Browse the repository at this point in the history

  3. Make sure the Conn object only calls the notifyDisconnect callbacks 

    once, by replacing the current subscription object with a new one
after delivering the notifications. A second call could mess up the
newer connection's state. (buildbot#4678)
    @YngveNPettersen
    YngveNPettersen committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    f9ffe15 View commit details
    Browse the repository at this point in the history