Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the React GUI for builders and workers #7458

Open
wants to merge 10 commits into
base: 3.11.x
Choose a base branch
from
Open

Improvements to the React GUI for builders and workers #7458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cafbfdf
Update Makefile to handle Windows paths and Python (Issue #6885)
YngveNPettersen Feb 28, 2024
db23429
Add Information about when build completed, instead of just when star…
YngveNPettersen Feb 26, 2024
ad1e14e
Add revision info column in BuildsTable.
YngveNPettersen Feb 26, 2024
c54839c
Let project configure max recent builds to display in Home app (Issue…
YngveNPettersen Feb 26, 2024
4b81903
Added retrieval of properties to be displayed as the build number in …
YngveNPettersen Feb 27, 2024
7197cc7
Make Builders page Tags column take less space when there are no tags
YngveNPettersen Feb 28, 2024
58d2192
squash! Update Makefile to handle Windows paths and Python (Issue #6885)
YngveNPettersen Feb 29, 2024
66742ff
fixup! Added retrieval of properties to be displayed as the build num…
YngveNPettersen Feb 29, 2024
482c58c
fixup! Update Makefile to handle Windows paths and Python (Issue #6885)
YngveNPettersen Feb 29, 2024
69f627a
fixup! Add Information about when build completed, instead of just wh…
YngveNPettersen Mar 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/build-time-info.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Display Information about when build completed, instead of just when it started
18 changes: 14 additions & 4 deletions www/react-base/src/components/BuildsTable/BuildsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,26 @@ export const BuildsTable = observer(({builds, builders}: BuildsTableProps) => {
)
: <></>;

const buildStartedCompletedElement = build.complete
? (
<span title={dateFormat(build.complete_at!)}>
{durationFormat(build.complete_at! - build.started_at)}
YngveNPettersen marked this conversation as resolved.
Show resolved Hide resolved
</span>
)
: (
<span title={dateFormat(build.started_at)}>
{durationFromNowFormat(build.started_at, now)}
YngveNPettersen marked this conversation as resolved.
Show resolved Hide resolved
</span>
);

return (
<tr key={build.id}>
{builderNameElement}
<td>
<BuildLinkWithSummaryTooltip build={build}/>
</td>
<td>
<span title={dateFormat(build.started_at)}>
{durationFromNowFormat(build.started_at, now)}
</span>
{buildStartedCompletedElement}
</td>
<td>
{buildCompleteInfoElement}
Expand Down Expand Up @@ -98,7 +108,7 @@ export const BuildsTable = observer(({builds, builders}: BuildsTableProps) => {
<tr>
{ builders !== null ? <td width="200px">Builder</td> : <></> }
<td width="100px">#</td>
<td width="150px">Started At</td>
<td width="150px">Completed At</td>
<td width="150px">Duration</td>
<td width="200px">Owners</td>
<td width="150px">Worker</td>
Expand Down