configurators: extend ConfiguratorBase to include more common fields … #7209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
reviewed
Dec 3, 2023
p12tic
approved these changes
Dec 17, 2023
|
@Mic92 The last changes broke tests. The result of setdefault does not need to be assigned. |
|
Yeah it should be self actually not c |
Mic92
force-pushed
the
configurator
branch
2 times, most recently
from
999cee4
to
cd5846c
Compare
|
Now it's assigned to self instead to c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and dry up the code
Contributor Checklist:
newsfragmentsdirectory (and read theREADME.txtin that directory)