debounce new buildrequests events #6286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
until_idle resets the timer when there is a new call, so that the method is only called once per burst
tardyp
force-pushed
the
sleep
branch
2 times, most recently
from
df2506c
to
eac7749
Compare
The brd has an api that can schedule several builders for requests, but we don't use it unless at startup. This change uses the debouncer so that we wait until there is no new buildrequest event for 1 s before starting them all
Codecov Report
@@ Coverage Diff @@
## master #6286 +/- ##
==========================================
- Coverage 92.02% 92.00% -0.02%
==========================================
Files 335 335
Lines 37627 37646 +19
==========================================
+ Hits 34625 34637 +12
- Misses 3002 3009 +7
Continue to review full report at Codecov.
|
tardyp
changed the title
p12tic
approved these changes
Nov 3, 2021
|
Needs rebase to get rid of commit already merged via #6287. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6285
new buildrequests arrive one by one in a burst. Problem is that the brd is triggered right at the first event, so all the fancy prioritization API we have are useless in this case.
This PR
The drawback of this technic is that the tests need to manage the time and to make sure to advance the time when they send a buildrequest