Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongo breadcrumb: Do not mask filter value nil #801

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

johnnyshields
Copy link
Contributor

@johnnyshields johnnyshields commented Oct 19, 2023

Goal

In Mongo queries, the value nil is a special in that it can impact the behavior of sparse indexes. Rather than masking it with "?" we should indicate that it is nil. There is no risk of this causing data leakage to the logs.

Design

This is implemented in the filter masking function.

Changeset

Only changes the Mongo breadcrumb functionality.

This also includes the changes from:

Testing

Tested in RSpec and by TableCheck in production.

@mclack
Copy link

mclack commented Oct 24, 2023

Hi @johnnyshields

Thanks for raising this. Along with the other PRs you have put forward, we will take a look at this when time allows.

@mclack mclack added feature request Request for a new feature backlog We hope to fix this feature/bug in the future labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants