Add support for generating CRD's for entities that contain other custom resources #823
+32
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gamingrobot Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a CustomKubernetesEntity that has another CustomKubernetesEntity as a property. We use this for cluster resources that create namespaced versions, so we want the spec to match without having to duplicate the spec inside the parent CustomKubernetesEntity. https://github.com/Contrast-Security-OSS/agent-operator/blob/master/src/Contrast.K8s.AgentOperator/Entities/V1Beta1ClusterAgentConnection.cs
In previous versions of the sdk the generator supported this scenario but the current one errors out with
System.ArgumentException: The given type Contrast.K8s.AgentOperator.Entities.V1Beta1AgentConfiguration is not a valid Kubernetes entity.inside the Map function.Also cleaned up the xml doc on the description attribute since the new generator doesn't support pulling the description from the xml summary.