feat(web-operator): add conversion webhooks #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
possible idea: use this version of conversion webhooks and hide them behind https://learn.microsoft.com/en-us/dotnet/api/system.runtime.versioning.requirespreviewfeaturesattribute?view=net-7.0 preview feature attribute. with that, we can let people test the feature and make some breaking changes inside normal versioning. |
buehler
force-pushed
the
feat/conversion-webhooks
branch
from
4da222e to
f968e0f
Compare
|
todo: generate CRD webhook info in CLI |
buehler
force-pushed
the
feat/conversion-webhooks
branch
2 times, most recently
from
08b1889 to
e869647
Compare
|
generating the resources is not really useful now. to attach conversion webhooks to CRDs, I need to generate all resources on the same level or as children. |
buehler
force-pushed
the
feat/conversion-webhooks
branch
from
e869647 to
cedd6fc
Compare
buehler
added a commit
that referenced
this pull request
Jan 17, 2024
This closes #137. This adds the preview version of conversion webhooks. The API is not stable yet and changes may happen in the future. They require the preview features flag to be set. BREAKING CHANGE: The CLI (which broke anyway...) does now generate everyting together and determines based on the project if there are webhooks or not. This results in one config folder instead of separate folders for CRD, RBAC, etc. With this, conversion webhooks can inject their configuration into the CRDs. Otherwise, this would be a cumbersome process. If the need for single topic generation arises again (for example only CRDs), then these generators can be added again.
buehler
added a commit
that referenced
this pull request
Jan 17, 2024
This closes #137. This adds the preview version of conversion webhooks. The API is not stable yet and changes may happen in the future. They require the preview features flag to be set. BREAKING CHANGE: The CLI (which broke anyway...) does now generate everyting together and determines based on the project if there are webhooks or not. This results in one config folder instead of separate folders for CRD, RBAC, etc. With this, conversion webhooks can inject their configuration into the CRDs. Otherwise, this would be a cumbersome process. If the need for single topic generation arises again (for example only CRDs), then these generators can be added again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #137