refactor(finalizer): Rework finalizer in controllers #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 2, 2023 17:25
buehler
added a commit
that referenced
this pull request
Jan 17, 2024
This also adds integration tests for the system. (and some todos). BREAKING CHANGE: Finalizers are registered with an identifier now. The identifier is generated by the KubeOps.Generator when used. Finalizers are attached via EntityFinalizerAttacher<> delegates that attach the finalizer to an entity.
buehler
added a commit
that referenced
this pull request
Jan 17, 2024
This also adds integration tests for the system. (and some todos). BREAKING CHANGE: Finalizers are registered with an identifier now. The identifier is generated by the KubeOps.Generator when used. Finalizers are attached via EntityFinalizerAttacher<> delegates that attach the finalizer to an entity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds integration tests for the system.
(and some todos).
BREAKING CHANGE: Finalizers are registered
with an identifier now. The identifier is
generated by the KubeOps.Generator when used.
Finalizers are attached via EntityFinalizerAttacher<>
delegates that attach the finalizer to an entity.