feat: use updated/faster JsonDiffPatch library #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertcoltheart
commented
Sep 12, 2023
|
Hey @robertcoltheart |
|
Sure, let me fix that issue Edit: Done, please re-check @buehler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation behind this change is to remove the deprecated transitive dependency
NetCoreApp 1.1fromJsonDiffPatch. This is causing validation issues in built images that are run through Aqua Trivy vulnerability scanner.A nice side-effect is that the diff should be much faster as it uses
System.Text.Jsoninstead ofNewtonsoft.Functionally, there should be no impact as both libraries adhere to
RFC 6902.@buehler