fix: make external svg files referred to in use tags work #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that when using html-to-image on our website it crashed with mysterious errors about invalid queries.
I realised that the code does not handle external files in use-tags in an inline SVG.
Motivation and Context
Fix for #425 (and also implicitly for #392 )
Also in order for the test case to be useful I reduced the allowed number of incorrect pixels from 100 to 2, thus somewhat addressing #426 it could possibly now be a little too sensitive on other platforms such as Windows that use a different font rendering, but at least the new test and all the old tests ran om my Mac.
Types of changes
Self Check before Merge