Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pt locale messages #79

Merged
merged 4 commits into from
Oct 20, 2019
Merged

Add pt locale messages #79

merged 4 commits into from
Oct 20, 2019

Conversation

fadc80
Copy link
Contributor

@fadc80 fadc80 commented Oct 19, 2019

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe: Add pt locale messages

Fixes

Issue Number:

What is the current behavior?

What is the new behavior?

Other information

@fadc80
Copy link
Contributor Author

fadc80 commented Oct 19, 2019

This is related to #76

@btzr-io
Copy link
Owner

btzr-io commented Oct 19, 2019

Awesome thanks!
Currently we don't have any framework to handle this but probably this files should exist on its own folder like: ./locales?

@btzr-io
Copy link
Owner

btzr-io commented Oct 19, 2019

@fadc80 Could you have the time to look into #80 ?

@fadc80
Copy link
Contributor Author

fadc80 commented Oct 19, 2019

Should I rebase and squash to a single commit?

@fadc80 fadc80 changed the title Add pt messages Add pt locale messages Oct 19, 2019
@btzr-io
Copy link
Owner

btzr-io commented Oct 20, 2019

@fadc80 Yes please 👍

@btzr-io btzr-io merged commit 645c993 into btzr-io:master Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants