validator: Move --rocksdb-fifo-shred-storage-size to deprecated list (s…

…olana-labs#3669)

This argument currently does nothing, and is also deprecated since the
use of fifo compaction on shred columns has been deprecated

validator/src/cli.rs

@@ -674,20 +674,6 @@ pub fn app<'a>(version: &'a str, default_args: &'a DefaultArgs) -> App<'a, 'a> {
                      'level': stores shreds using RocksDB's default (level) compaction.",
                 ),
         )
-        .arg(
-            Arg::with_name("rocksdb_fifo_shred_storage_size")
-                .long("rocksdb-fifo-shred-storage-size")
-                .value_name("SHRED_STORAGE_SIZE_BYTES")
-                .takes_value(true)
-                .validator(is_parsable::<u64>)
-                .help(
-                    "The shred storage size in bytes. The suggested value is at least 50% of your \
-                     ledger storage size. If this argument is unspecified, we will assign a \
-                     proper value based on --limit-ledger-size. If --limit-ledger-size is not \
-                     presented, it means there is no limitation on the ledger size and thus \
-                     rocksdb_fifo_shred_storage_size will also be unbounded.",
-                ),
-        )
         .arg(
             Arg::with_name("rocksdb_ledger_compression")
                 .hidden(hidden_unless_forced())
@@ -2151,6 +2137,19 @@ fn deprecated_arguments() -> Vec<DeprecatedArg> {
         .value_name("ROCKSDB_COMPACTION_INTERVAL_SLOTS")
         .takes_value(true)
         .help("Number of slots between compacting ledger"));
+    // Deprecated in v2.2
+    add_arg!(Arg::with_name("rocksdb_fifo_shred_storage_size")
+        .long("rocksdb-fifo-shred-storage-size")
+        .value_name("SHRED_STORAGE_SIZE_BYTES")
+        .takes_value(true)
+        .validator(is_parsable::<u64>)
+        .help(
+            "The shred storage size in bytes. The suggested value is at least 50% of your ledger \
+             storage size. If this argument is unspecified, we will assign a proper value based \
+             on --limit-ledger-size. If --limit-ledger-size is not presented, it means there is \
+             no limitation on the ledger size and thus rocksdb_fifo_shred_storage_size will also \
+             be unbounded.",
+        ));
     add_arg!(Arg::with_name("rocksdb_max_compaction_jitter")
         .long("rocksdb-max-compaction-jitter-slots")
         .value_name("ROCKSDB_MAX_COMPACTION_JITTER_SLOTS")