Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AN-146] Emit VM cost for GCP Batch #7582

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

[AN-146] Emit VM cost for GCP Batch #7582

wants to merge 6 commits into from

Conversation

lucymcnatt
Copy link

@lucymcnatt lucymcnatt commented Nov 19, 2024 •
edited
Loading

Description

AN-146

Adds BatchPollResultMonitorActor.extractVmInfoFromRunState so that the /cost endpoint functions correctly for workflows run on GCP Batch

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@lucymcnatt lucymcnatt changed the title [AN-146] Calculate VM cost for GCP Batch [AN-146] Emit VM cost for GCP Batch Nov 20, 2024
@lucymcnatt lucymcnatt marked this pull request as ready for review November 21, 2024 15:23
@lucymcnatt lucymcnatt requested a review from a team as a code owner November 21, 2024 15:23
@lucymcnatt lucymcnatt marked this pull request as draft November 21, 2024 19:53
@lucymcnatt
Copy link
Author

putting it back in draft while I supply the vmInfo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgainerdewar jgainerdewar jgainerdewar left review comments

@aednichols aednichols aednichols left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucymcnatt @aednichols @jgainerdewar